Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: enable revive for planner/core/optimizer.go #44102

Closed
wants to merge 2 commits into from
Closed

linter: enable revive for planner/core/optimizer.go #44102

wants to merge 2 commits into from

Conversation

Cavan-xu
Copy link
Contributor

@Cavan-xu Cavan-xu commented May 23, 2023 •
edited by hawkingrei
Loading

What problem does this PR solve?

Issue Number: ref #40786

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2023

Welcome @Cavan-xu!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2023

Hi @Cavan-xu. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-bot
Copy link
Contributor

sre-bot commented May 23, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hawkingrei hawkingrei changed the title fix:planner/core/optimizer.go linter: enable revive for planner/core/optimizer.go May 23, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@hawkingrei hawkingrei closed this May 23, 2023
@hawkingrei hawkingrei reopened this May 23, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 23, 2023
@hawkingrei
Copy link
Member

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please sign the CLA.

@hawkingrei
Copy link
Member

/retest

Cavan-xu added 2 commits May 23, 2023 17:25
@Cavan-xu
fix:planner/core/optimizer.go
981da25 
Signed-off-by: cavan.xu <[email protected]>
@Cavan-xu
fix:lint
e4c8617 
Signed-off-by: cavan.xu <[email protected]>
@Cavan-xu Cavan-xu force-pushed the fix/revive/exclude_files branch from 1c5bd0c to e4c8617 Compare May 23, 2023 09:27
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2023

@Cavan-xu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 1c5bd0cf9881241eb6dc729acec17b0cfd5804b1 link true /test build
idc-jenkins-ci-tidb/unit-test e4c8617 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 e4c8617 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Cavan-xu Cavan-xu closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cavan-xu @sre-bot @hawkingrei